Skip to content
This repository was archived by the owner on Jun 3, 2025. It is now read-only.

Conversation

rahul-tuli
Copy link
Member

This reverts commit 960cae2.

  • Catch HttpError over exception

  • Catch HttpError over exception when checking country

(cherry picked from commit 9b5a0bd)

* Revert "Suppress analytics errors and messages (#318)"

This reverts commit 960cae2.

* Catch HttpError over exception

* Catch HttpError over exception when checking country

(cherry picked from commit 9b5a0bd)
@rahul-tuli rahul-tuli self-assigned this May 31, 2023
@rahul-tuli rahul-tuli added bug Something isn't working 1.5 release labels May 31, 2023
@rahul-tuli rahul-tuli changed the title [Cheery pick] Sparsezoo stdout fix (#322) [Cherry pick] Sparsezoo stdout fix (#322) Jun 1, 2023
Copy link
Contributor

@dbogunowicz dbogunowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was this commit reverted in main in the first place?

@KSGulin KSGulin merged commit 08fa9dc into release/1.5 Jun 1, 2023
@KSGulin KSGulin deleted the cherry-pick-revert-suppression-of-std-streams branch June 1, 2023 11:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
1.5 release bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants