This repository was archived by the owner on Jun 3, 2025. It is now read-only.
Download iso chunk folder #470
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bfineran
reviewed
Feb 28, 2024
…arsezoo into download-iso-chunk-folder
bfineran
previously approved these changes
Feb 29, 2024
bfineran
reviewed
Feb 29, 2024
rahul-tuli
approved these changes
Feb 29, 2024
bfineran
approved these changes
Feb 29, 2024
horheynm
added a commit
that referenced
this pull request
Feb 29, 2024
* add more info on what chunk is downloading, and make chunk folder foe each file * fix bug * comments * add .cache/sparsezoo/neuralmagic/
bfineran
pushed a commit
that referenced
this pull request
Feb 29, 2024
* add more info on what chunk is downloading, and make chunk folder foe each file (#469) * Download iso chunk folder (#470) * add more info on what chunk is downloading, and make chunk folder foe each file * fix bug * comments * add .cache/sparsezoo/neuralmagic/ --------- Co-authored-by: Rahul Tuli <rahul@neuralmagic.com>
bfineran
pushed a commit
that referenced
this pull request
Mar 8, 2024
* add more info on what chunk is downloading, and make chunk folder foe each file (#469) * Download iso chunk folder (#470) * add more info on what chunk is downloading, and make chunk folder foe each file * fix bug * comments * add .cache/sparsezoo/neuralmagic/ * Multiple download bug (#476) * src/sparsezoo/utils/download.py * revert readme"
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous commit fails bc the chunks are saved in root model folder.
Tests checks the expected files, where chunks are not included.
Before these commits, chunk folder is deleted each run so it passed. Now if multiple downloading is running, then delete of a folder will have directory to write to
Chunks are now saved in
~/.cache/sparsezoo/neuralmagic/chunks/{stub}/{training_or_deployment_or_folder_name}/{model_data}/chunk1Combined chunks are saved in
Chunks are now saved in
~/.cache/sparsezoo/neuralmagic/{stub}/training/model.data