newhinton: Expose image api for other clients as api v1.4 including routes fix #1600
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oli-ver
force-pushed
the
feature/noid/stableAttachmentId
branch
from
d335138 to
cc83bb3
Compare
oli-ver
changed the title
enjeck
reviewed
Aug 8, 2025
oli-ver
added a commit
to oli-ver/notes
that referenced
this pull request
Aug 9, 2025
Updates the date of the contribution Adds missing parameter documentation Adds example curl requests how to call the API Use term attachment instead of image to make more generic Resolves review comment nextcloud#1600 (comment) Signed-off-by: oli-ver <oli-ver@users.noreply.github.com>
oli-ver
added a commit
to oli-ver/notes
that referenced
this pull request
Aug 9, 2025
Updates the date of the contribution Adds missing parameter documentation Adds example curl requests how to call the API Use term attachment instead of image to make more generic Resolves review comment nextcloud#1600 (comment) Signed-off-by: oli-ver <oli-ver@users.noreply.github.com>
oli-ver
force-pushed
the
feature/noid/stableAttachmentId
branch
from
e3dec3c to
2307313
Compare
Welcome :) Just rebased on main and rested, looks good to me. |
enjeck
previously requested changes
Aug 9, 2025
|
Also, for the Block unconventional commit check, you can just edit all commit messages to be prefixed with |
Signed-off-by: Felix Nüsse <felix.nuesse@t-online.de>
Signed-off-by: oli-ver <oli-ver@users.noreply.github.com>
Updates the date of the contribution Adds missing parameter documentation Adds example curl requests how to call the API Use term attachment instead of image to make more generic Resolves review comment nextcloud#1600 (comment) Signed-off-by: oli-ver <oli-ver@users.noreply.github.com>
Signed-off-by: oli-ver <oli-ver@users.noreply.github.com>
Signed-off-by: oli-ver <oli-ver@users.noreply.github.com>
oli-ver
force-pushed
the
feature/noid/stableAttachmentId
branch
from
2307313 to
2137827
Compare
Signed-off-by: oli-ver <oli-ver@users.noreply.github.com>
oli-ver
force-pushed
the
feature/noid/stableAttachmentId
branch
from
bfbc6eb to
4183669
Compare
|
@enjeck I think I now covered all of that. Can you please recheck? |
This was referenced Aug 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the routing discussed in #826
Rebases the code provided by @newhinton on main, extends PR #1123