-
Notifications
You must be signed in to change notification settings - Fork 103
Refactored card usage to remove card-layout shortcode #923
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…usage (#818) feat: Rewrote main landing page to be in markdown + updated card shortcode usage
* feat: Rewrote main landing page to be in markdown + updated card shortcode usage * Update card params correctly * chore: Refactored icon usage to use new shortcode * Removed brand icons * Removed final few brand icons
archetypes/landing-page.md
Outdated
{{</card>}} | ||
{{</card-section>}} | ||
{{</card-layout>}} | ||
{{<card-section isFeaturedSection="true">}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
{{<card-section isFeaturedSection="true">}} | |
{{<card-section isFeaturedSection="true">}} |
Double-space. This applies to all versions of this change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but there's excess whitespace in the section declaration.
77658e2
to
b596820
Compare
This branch is just completely broken. Will make a new one |
Checklist
Before sharing this pull request, I completed the following checklist:
Footnotes
Potentially sensitive information includes personally identify information (PII), authentication credentials, and live URLs. Refer to the style guide for guidance about placeholder content. ↩