Skip to content

Refactored card usage to remove card-layout shortcode #923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 9 commits into from

Conversation

lamATnginx
Copy link
Contributor

@lamATnginx lamATnginx commented Aug 5, 2025

Checklist

Before sharing this pull request, I completed the following checklist:

Footnotes

  1. Potentially sensitive information includes personally identify information (PII), authentication credentials, and live URLs. Refer to the style guide for guidance about placeholder content.

nginx-jack and others added 8 commits July 25, 2025 10:14
…usage (#818)

feat: Rewrote main landing page to be in markdown + updated card shortcode usage
* feat: Rewrote main landing page to be in markdown + updated card shortcode usage

* Update card params correctly

* chore: Refactored icon usage to use new shortcode

* Removed brand icons

* Removed final few brand icons
@lamATnginx lamATnginx self-assigned this Aug 5, 2025
@lamATnginx lamATnginx requested a review from a team as a code owner August 5, 2025 19:52
@lamATnginx lamATnginx added the enhancement New feature or request label Aug 5, 2025
@lamATnginx lamATnginx requested review from a team as code owners August 5, 2025 19:52
@github-actions github-actions bot added documentation Improvements or additions to documentation product/nginx-one Issues related to NGINX One Console product/nginxaas Issues related to NGINX as a Service for Azure product/agent Issues related to NGINX Agent product/unit NGINX Unit tooling Back end, repository, Hugo, and all things not related to content labels Aug 5, 2025
@lamATnginx lamATnginx marked this pull request as draft August 5, 2025 19:52
{{</card>}}
{{</card-section>}}
{{</card-layout>}}
{{<card-section isFeaturedSection="true">}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{{<card-section isFeaturedSection="true">}}
{{<card-section isFeaturedSection="true">}}

Double-space. This applies to all versions of this change.

Copy link
Contributor

@ADubhlaoich ADubhlaoich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but there's excess whitespace in the section declaration.

@nginx-jack nginx-jack force-pushed the mainframe branch 2 times, most recently from 77658e2 to b596820 Compare August 18, 2025 13:49
@github-actions github-actions bot added product/nim Issues related to NGINX Instance Manager product/nginx-plus Issues related to NGINX Plus (and NGINX Open Source in docs.nginx.com) product/controller Issues related to NGINX Controller (EOS product) product/mesh Issues related to NGINX Service Mesh (EOS product) product/nms Issues related to NGINX Management Suite (EOS product) labels Aug 18, 2025
@lamATnginx lamATnginx marked this pull request as ready for review August 18, 2025 15:41
@lamATnginx
Copy link
Contributor Author

This branch is just completely broken. Will make a new one

@lamATnginx lamATnginx closed this Aug 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request product/agent Issues related to NGINX Agent product/controller Issues related to NGINX Controller (EOS product) product/mesh Issues related to NGINX Service Mesh (EOS product) product/nginx-one Issues related to NGINX One Console product/nginx-plus Issues related to NGINX Plus (and NGINX Open Source in docs.nginx.com) product/nginxaas Issues related to NGINX as a Service for Azure product/nim Issues related to NGINX Instance Manager product/nms Issues related to NGINX Management Suite (EOS product) product/unit NGINX Unit tooling Back end, repository, Hugo, and all things not related to content
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants