Skip to content

fix: removes Extra keyword from volumeMounts and Volumes for the data… #3588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 3, 2025

Conversation

vazkarvishal
Copy link
Contributor

… plane

Proposed changes

Fixing 3585

Problem: Incorrect Helm Schema for the data plane volume mounts.

Solution: Explain the approach you took to implement the solution, highlighting any significant design decisions or
considerations.

Testing: Deployed it on my cluster to see if failure of schema validation does not occur anymore

Closes #3585

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

fix: removes Extra keyword from volumeMounts and Volumes for the data…

fix: removes Extra keyword from volumeMounts and Volumes for the data…

Copy link

nginx-bot bot commented Jul 3, 2025

Hi @vazkarvishal! Welcome to the project! 🎉

Thanks for opening this pull request!
Be sure to check out our Contributing Guidelines while you wait for someone on the team to review this.

Copy link
Contributor

github-actions bot commented Jul 3, 2025

✅ All required contributors have signed the F5 CLA for this PR. Thank you!
Posted by the CLA Assistant Lite bot.

@github-actions github-actions bot added the helm-chart Relates to helm chart label Jul 3, 2025
@vazkarvishal
Copy link
Contributor Author

I have hereby read the F5 CLA and agree to its terms

@sjberman sjberman merged commit 4ccd74f into nginx:main Jul 3, 2025
48 checks passed
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in NGINX Gateway Fabric Jul 3, 2025
sjberman pushed a commit that referenced this pull request Jul 4, 2025
#3588)

fix: removes Extra keyword from volumeMounts and Volumes for the data plane
sjberman added a commit that referenced this pull request Jul 7, 2025
#3592)

fix: removes Extra keyword from volumeMounts and Volumes for the data… (#3588)

fix: removes Extra keyword from volumeMounts and Volumes for the data plane

Co-authored-by: Vishal Vazkar <vazkarvishal@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Ability to pass custom Nginx configs to the data plane
3 participants