Skip to content

Add connection to NGINX One Console #3676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Aug 6, 2025
Merged

Add connection to NGINX One Console #3676

merged 16 commits into from
Aug 6, 2025

Conversation

bjee19
Copy link
Contributor

@bjee19 bjee19 commented Jul 31, 2025

Proposed changes

Add connection to NGINX One Console by configuring Agent to sent telemetry data to NGINX One Console endpoint.

Problem: Users of NGF and NGINX One Console would like to see fleet management telemetry in their console.

Solution: Update NGINX Agent configuration to send telemetry data to NGINX One Console when a user specifies their data plane key secret.

Testing: Added unit tests and manually verified NGF metrics are sent to the NGINX One Console when using a staging endpoint.

Closes #3251

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.

Enable connection to NGINX One Console.

@github-actions github-actions bot added documentation Improvements or additions to documentation enhancement New feature or request helm-chart Relates to helm chart labels Jul 31, 2025
@bjee19
Copy link
Contributor Author

bjee19 commented Jul 31, 2025

This PR is still a draft until i finish updating the objects_test.go and add tests for the agent_labels.go collector

Copy link

codecov bot commented Jul 31, 2025

Codecov Report

❌ Patch coverage is 89.56522% with 24 lines in your changes missing coverage. Please review.
✅ Project coverage is 87.11%. Comparing base (316db99) to head (85dbd0b).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/controller/manager.go 0.00% 12 Missing ⚠️
cmd/gateway/commands.go 91.54% 6 Missing ⚠️
internal/controller/provisioner/handler.go 25.00% 2 Missing and 1 partial ⚠️
internal/controller/provisioner/provisioner.go 88.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3676      +/-   ##
==========================================
+ Coverage   87.05%   87.11%   +0.05%     
==========================================
  Files         127      128       +1     
  Lines       15604    15788     +184     
  Branches       62       62              
==========================================
+ Hits        13584    13753     +169     
- Misses       1861     1873      +12     
- Partials      159      162       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Collaborator

@sjberman sjberman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sidenote regarding documentation, be sure we update the cli-help doc for the new CLI flags.

@github-project-automation github-project-automation bot moved this from 🆕 New to 🏗 In Progress in NGINX Gateway Fabric Jul 31, 2025
@bjee19 bjee19 marked this pull request as ready for review August 5, 2025 20:22
@bjee19 bjee19 requested a review from a team as a code owner August 5, 2025 20:22
@bjee19 bjee19 requested a review from sjberman August 5, 2025 20:23
@bjee19
Copy link
Contributor Author

bjee19 commented Aug 5, 2025

There are some weird tests included just to satisfy the codecov bot and I think thats the highest the coverage is getting since the remaining spots are already lacking coverage.

Copy link
Collaborator

@sjberman sjberman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you verified that if a user updates the source Secret, that key is propagated properly to the duplicate Secret?

@bjee19
Copy link
Contributor Author

bjee19 commented Aug 5, 2025

Have you verified that if a user updates the source Secret, that key is propagated properly to the duplicate Secret?

Yep just verified that.

@salonichf5
Copy link
Contributor

lgtm 🚀 great work !

@bjee19 bjee19 force-pushed the enh/n1c-connection branch from d23f268 to 4a2262b Compare August 6, 2025 18:30
@bjee19 bjee19 enabled auto-merge (squash) August 6, 2025 19:14
@bjee19 bjee19 merged commit f058043 into main Aug 6, 2025
79 of 80 checks passed
@bjee19 bjee19 deleted the enh/n1c-connection branch August 6, 2025 19:19
@github-project-automation github-project-automation bot moved this from 🏗 In Progress to ✅ Done in NGINX Gateway Fabric Aug 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request helm-chart Relates to helm chart release-notes
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Enable Connection to NGINX One Console
3 participants