-
Notifications
You must be signed in to change notification settings - Fork 131
Add connection to NGINX One Console #3676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This PR is still a draft until i finish updating the objects_test.go and add tests for the agent_labels.go collector |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #3676 +/- ##
==========================================
+ Coverage 87.05% 87.11% +0.05%
==========================================
Files 127 128 +1
Lines 15604 15788 +184
Branches 62 62
==========================================
+ Hits 13584 13753 +169
- Misses 1861 1873 +12
- Partials 159 162 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sidenote regarding documentation, be sure we update the cli-help doc for the new CLI flags.
There are some weird tests included just to satisfy the codecov bot and I think thats the highest the coverage is getting since the remaining spots are already lacking coverage. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you verified that if a user updates the source Secret, that key is propagated properly to the duplicate Secret?
Yep just verified that. |
lgtm 🚀 great work ! |
d23f268
to
4a2262b
Compare
Proposed changes
Add connection to NGINX One Console by configuring Agent to sent telemetry data to NGINX One Console endpoint.
Problem: Users of NGF and NGINX One Console would like to see fleet management telemetry in their console.
Solution: Update NGINX Agent configuration to send telemetry data to NGINX One Console when a user specifies their data plane key secret.
Testing: Added unit tests and manually verified NGF metrics are sent to the NGINX One Console when using a staging endpoint.
Closes #3251
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.