-
Notifications
You must be signed in to change notification settings - Fork 131
Fix policy attachment when ancestors slice is full #3698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
sarthyparty
merged 18 commits into
nginx:main
from
sarthyparty:bug/handle-policy-ancestor
Aug 15, 2025
Merged
Fix policy attachment when ancestors slice is full #3698
sarthyparty
merged 18 commits into
nginx:main
from
sarthyparty:bug/handle-policy-ancestor
Aug 15, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b5891a0
to
3041aa9
Compare
e02c8bb
to
624fd46
Compare
sjberman
reviewed
Aug 12, 2025
5a0abd0
to
ad62fba
Compare
sjberman
reviewed
Aug 14, 2025
34594c9
to
2b2a2b6
Compare
sjberman
reviewed
Aug 14, 2025
salonichf5
reviewed
Aug 14, 2025
salonichf5
reviewed
Aug 14, 2025
salonichf5
reviewed
Aug 14, 2025
salonichf5
reviewed
Aug 14, 2025
salonichf5
reviewed
Aug 14, 2025
ciarams87
approved these changes
Aug 15, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! I tested it locally and everything seems to be working as expected.
Excellent work @sarthyparty 🥳!🔥 🔥 🔥
salonichf5
approved these changes
Aug 15, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
cee735f
to
0ae3ca8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Problem: Multiple bugs when ancestor slice was full:
Solution: Added conditions to ancestor and logs to controller. I fixed BackendTLSPolicy to add attachments until ancestors became full and fixed NGF policies as well
Testing: Currently unit tests and manual tested
Please focus on (optional): If you any specific areas where you would like reviewers to focus their attention or provide
specific feedback, add them here.
Closes #1987
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.