Skip to content

test: mark test-inspector-network-fetch as flaky on Windows #59091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 17, 2025
Merged

test: mark test-inspector-network-fetch as flaky on Windows #59091

merged 1 commit into from
Jul 17, 2025
+2 −0

Conversation

joyeecheung
Copy link
Member

@joyeecheung joyeecheung commented Jul 16, 2025 •
edited
Loading

The first failure happened in #58077 which is likely related. @islandryu is investigating but meanwhile IMO it would be better to mark it as flaky to unblock the CI since this has failed a lot of Windows CIs since the security embargo is lifted. (https://ci.nodejs.org/job/node-test-binary-windows-js-suites/ is almost all red)

Refs: #59090

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Jul 16, 2025
@joyeecheung joyeecheung added the fast-track PRs that do not need to wait for 48 hours to land. label Jul 16, 2025
@github-actions GitHub Actions
Copy link
Contributor

Fast-track has been requested by @joyeecheung. Please 👍 to approve.

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jul 16, 2025 •
edited by joyeecheung
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/67969/ ⏸️

@codecov Codecov
Copy link

codecov bot commented Jul 16, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.05%. Comparing base (049664b) to head (863fcff).
Report is 16 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #59091      +/-   ##
==========================================
- Coverage   90.06%   90.05%   -0.02%     
==========================================
  Files         645      645              
  Lines      189130   189153      +23     
  Branches    37094    37097       +3     
==========================================
  Hits       170339   170339              
- Misses      11511    11515       +4     
- Partials     7280     7299      +19

see 36 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

islandryu
islandryu approved these changes Jul 17, 2025
View reviewed changes
Copy link
Member

@islandryu islandryu left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the change!
I'm currently investigating it.

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/67977/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/67981/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/67982/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/67990/

@joyeecheung joyeecheung added the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 17, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 17, 2025
@nodejs-github-bot nodejs-github-bot merged commit b16a0e7 into nodejs:main Jul 17, 2025
68 of 70 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in b16a0e7

@IlyasShabi IlyasShabi mentioned this pull request Jul 18, 2025
Merged
@Sylphy-0xd3ac Sylphy-0xd3ac mentioned this pull request Jul 19, 2025
Closed
aduh95 pushed a commit that referenced this pull request Jul 21, 2025
@joyeecheung @aduh95
test: mark test-inspector-network-fetch as flaky on Windows
a9511a6 
PR-URL: #59091
Refs: #59090
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Ryuhei Shima <shimaryuhei@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
@github-actions github-actions bot mentioned this pull request Jul 28, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@panva panva panva approved these changes

@legendecas legendecas legendecas approved these changes

@islandryu islandryu islandryu approved these changes

Assignees
No one assigned
Labels
fast-track PRs that do not need to wait for 48 hours to land. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@joyeecheung @nodejs-github-bot @panva @legendecas @islandryu