This repository was archived by the owner on Apr 30, 2021. It is now read-only.
Implement a svg backend #128
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(Also remove propTypes because they were wrong)
… since render changes)
Codecov Report
@@ Coverage Diff @@
## master #128 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 1 1
Lines 49 66 +17
=====================================
+ Hits 49 66 +17
Continue to review full report at Codecov.
|
|
This looks good. I just feel |
|
Since the PropTypes don't seem much relevant, we can take them off rollup config and package.json? |
|
On it! |
Upgrade dependencies. Fix eslint config.
|
I just formatted the code with prettier too. |
ooade
approved these changes
Feb 7, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This relies on a hack (
NodeMounter) to insert svg nodes created by roughjs in the react tree and it adds a backgroundColor style prop to svg instead of clearing canvas.This should fix #116