Skip to content

[OTAGENT-412] Updated modules adding ability for serialize exporter to set proxy variables #41041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

tim-liakh-datadog
Copy link
Contributor

@tim-liakh-datadog tim-liakh-datadog commented Jul 1, 2025

Description

This PR improves the serializer exporter by introducing support for HTTP proxy settings via both environment variables and explicit configuration.

  • The exporter now reads from the standard environment variables: HTTP_PROXY, HTTPS_PROXY, and NO_PROXY.
  • A new proxy_url field was added to the exporter's configuration. If set, this will override the environment variables.

Testing

Added new unit tests and manually tested with proxy applciation.

Related PR

DataDog/datadog-agent#38224

@tim-liakh-datadog tim-liakh-datadog requested review from mx-psi, songy23 and a team as code owners July 1, 2025 14:05
Copy link

linux-foundation-easycla bot commented Jul 1, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

@tim-liakh-datadog tim-liakh-datadog changed the title [OTAGENT-412] Updated modules adding ability for serialize exporter to set proxy va… [OTAGENT-412] Updated modules adding ability for serialize exporter to set proxy variables Jul 1, 2025
@songy23
Copy link
Member

songy23 commented Jul 1, 2025

Can you also add a test in http://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/exporter/datadogexporter/metrics_exporter_test.go ? You can test proxy with httputil.ReverseProxy

Copy link
Member

@songy23 songy23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please rebase / merge main

@songy23
Copy link
Member

songy23 commented Jul 7, 2025

still need to fix merge conflicts

@songy23
Copy link
Member

songy23 commented Jul 7, 2025

There are still CI failures

@songy23
Copy link
Member

songy23 commented Jul 7, 2025

@songy23 songy23 merged commit 7592deb into open-telemetry:main Jul 7, 2025
177 checks passed
@github-actions github-actions bot added this to the next release milestone Jul 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants