Add experimental http client url.template attribute #13581
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trask
approved these changes
Mar 26, 2025
| } | ||
|
|
||
| @Override | ||
| public String extract(REQUEST request) { | ||
| String method = getter.getHttpRequestMethod(request); | ||
| if (method == null || !knownMethods.contains(method)) { | ||
| String template = urlTemplateExtractor.apply(request); |
There was a problem hiding this comment.
small preference to move this line down just before the last line of the method
There was a problem hiding this comment.
I did the same change for route in the server extractor.
jaydeluca
approved these changes
Mar 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add filling
url.templatetoHttpExperimentalAttributesExtractor. Also modifyHttpSpanNameExtractorto use the url template in http client span name.