Fix instrumentation failure when constructor has @WithSpan annotation #13929
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #13920
This PR excludes constructors from
@WithSpan
instrumentation since it currently does not work at all. This is not ideal as@WithSpan
annotation is allowed on constructors, I don't think we can change that.Implementing
@WithSpan
support for constructors is slightly problematic because as far as I can tell on constructors byte buddy does not allowOnMethodExit
withonThrowable
.