-
Notifications
You must be signed in to change notification settings - Fork 6.2k
8365919: Replace currentTimeMillis with nanoTime in Stresser.java #26879
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
👋 Welcome back ayang! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
@albertnetymk To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command. Applicable Labels
|
/cc hotspot-gc |
@albertnetymk |
Webrevs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You might want to load (options.getTime() * 1000) into a local rather than compute it multiple times.
Extracted that to a local var for |
Mostly a mechanic change from
currentTimeMillis()
tonanoTime()/1000000
. It also removesfinishTime
to avoid overflowing.The change in
iteration()
is to ensurecurrentTime
is properly initialized.(Was investigating a timeout on Windows-x64, which led me to this code. I think this fix is good enough by its own.)
Test: tier1-5
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26879/head:pull/26879
$ git checkout pull/26879
Update a local copy of the PR:
$ git checkout pull/26879
$ git pull https://git.openjdk.org/jdk.git pull/26879/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 26879
View PR using the GUI difftool:
$ git pr show -t 26879
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26879.diff
Using Webrev
Link to Webrev Comment