8365909: [REDO] Add a compilation timeout flag to catch long running compilations

[mhaessig]

This PR adds a timeout for compilation tasks based on timer signals on Linux debug builds.

This PR is a redo of #25872 with fixes for the failing test.

Testing:

• Github Actions
• tier1,tier2 plus internal testing on all Oracle supproted platforms
• tier3,tier4 on linux-x64-debug
• tier1,tier2,tier3,tier4 on linux-x64-debug with -XX:CompileTaskTimeout=60000

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8365909: [REDO] Add a compilation timeout flag to catch long running compilations (Enhancement - P4)

Reviewers

• Dean Long (@dean-long - Reviewer)
• Christian Hagedorn (@chhagedorn - Reviewer)

Contributors

• Dean Long <dlong@openjdk.org>

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26882/head:pull/26882
$ git checkout pull/26882

Update a local copy of the PR:
$ git checkout pull/26882
$ git pull https://git.openjdk.org/jdk.git pull/26882/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26882

View PR using the GUI difftool:
$ git pr show -t 26882

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26882.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back mhaessig! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@mhaessig This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8365909: [REDO] Add a compilation timeout flag to catch long running compilations

Co-authored-by: Dean Long <dlong@openjdk.org>
Reviewed-by: dlong, chagedorn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 28 new commits pushed to the master branch:

• 603526b: 8364768: JDK javax.imageio ImageWriters do not all flush the output stream
• c01b4fc: 8365814: Consolidate has_been_archived() and has_been_buffered() in ArchiveBuilder
• ae0dac4: 8361613: System.console() should only be available for interactive terminal
• ... and 25 more: https://git.openjdk.org/jdk/compare/5febc4e3bb1f47f69fc28c266a775e19cbac9e5f...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@mhaessig The following label will be automatically applied to this pull request:

• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mhaessig]

/label add hotspot-compiler

[openjdk]

@mhaessig
The hotspot-compiler label was successfully added.

[mhaessig]

/label remove hotspot

[mhaessig]

/contributor add @dean-long

[openjdk]

@mhaessig
The hotspot label was successfully removed.

[openjdk]

@mhaessig
Contributor Dean Long <dlong@openjdk.org> successfully added.

[mlbridge]

Webrevs

• 00: Full (f86361c8)

[dean-long]

Please explain the test fix.

[mhaessig]

I originally ran java -version and checked that the string "java version" appeared in the output. Then, Christian suggested that I really should use java --version, which I promptly started using. However, java --version's output is java <version number> and does not contain "java version" making the test fail. This combined with my forgetting to run testing before integration, lead to the backout.

Now, the last run of java --version that does not time out only checks that the exit code is 0, because I noticed that java --version might also output something else than "java" and checking for successful exit is sufficient to show that the test did not assert.

[chhagedorn]

Looks good to me, too!

[chhagedorn]

The ifdef should probably also be without indentation like the other ifdefs:

Suggested change

	#ifdef MUSL_LIBC
	sev.sigev_notify_thread_id = thread->osthread()->thread_id();
	#else
	sev._sigev_un._tid = thread->osthread()->thread_id();
	#endif // MUSL_LIBC
	#ifdef MUSL_LIBC
	sev.sigev_notify_thread_id = thread->osthread()->thread_id();
	#else
	sev._sigev_un._tid = thread->osthread()->thread_id();
	#endif // MUSL_LIBC