-
Notifications
You must be signed in to change notification settings - Fork 6.2k
8365937: post_method_exit might incorrectly set was_popped_by_exception and value in the middle of stack unwinding #26886
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
lmesnik
wants to merge
24
commits into
openjdk:master
Choose a base branch
from
lmesnik:8365937
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+329
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ptionOccurred.java Co-authored-by: David Holmes <62092539+dholmes-ora@users.noreply.github.com>
Co-authored-by: David Holmes <62092539+dholmes-ora@users.noreply.github.com>
…ptionOccurred/libExceptionOccurred.cpp Co-authored-by: David Holmes <62092539+dholmes-ora@users.noreply.github.com>
👋 Welcome back lmesnik! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
Webrevs
|
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
hotspot
hotspot-dev@openjdk.org
rfr
Pull request is ready for review
serviceability
serviceability-dev@openjdk.org
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The void
JvmtiExport::post_method_exit(JavaThread* thread, Method* method, frame current_frame)
calculatesbool exception_exit = state->is_exception_detected() && !state->is_exception_caught();
to find if method exit normally or by exception.
However, JvmtiExport::post_method_exit( method is not called at all in the case of exception. See
void JvmtiExport::notice_unwind_due_to_exception(JavaThread *thread, Method* method, address location, oop exception, bool in_handler_frame)
where post_method_exit_inner is called directly.
The
exception_exit
is true when exception is processed and the current method is called in the middle of stack unwinding.The fix was a part of
#26713
for
https://bugs.openjdk.org/browse/JDK-8365192
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26886/head:pull/26886
$ git checkout pull/26886
Update a local copy of the PR:
$ git checkout pull/26886
$ git pull https://git.openjdk.org/jdk.git pull/26886/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 26886
View PR using the GUI difftool:
$ git pr show -t 26886
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26886.diff
Using Webrev
Link to Webrev Comment