Skip to content

8365937: post_method_exit might incorrectly set was_popped_by_exception and value in the middle of stack unwinding #26886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 24 commits into
base: master
Choose a base branch
from

Conversation

lmesnik
Copy link
Member

@lmesnik lmesnik commented Aug 21, 2025

The void JvmtiExport::post_method_exit(JavaThread* thread, Method* method, frame current_frame) calculates
bool exception_exit = state->is_exception_detected() && !state->is_exception_caught();
to find if method exit normally or by exception.
However, JvmtiExport::post_method_exit( method is not called at all in the case of exception. See
void JvmtiExport::notice_unwind_due_to_exception(JavaThread *thread, Method* method, address location, oop exception, bool in_handler_frame)
where post_method_exit_inner is called directly.

The exception_exit is true when exception is processed and the current method is called in the middle of stack unwinding.

The fix was a part of
#26713
for
https://bugs.openjdk.org/browse/JDK-8365192


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8365937: post_method_exit might incorrectly set was_popped_by_exception and value in the middle of stack unwinding (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26886/head:pull/26886
$ git checkout pull/26886

Update a local copy of the PR:
$ git checkout pull/26886
$ git pull https://git.openjdk.org/jdk.git pull/26886/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26886

View PR using the GUI difftool:
$ git pr show -t 26886

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26886.diff

Using Webrev

Link to Webrev Comment

@lmesnik lmesnik marked this pull request as ready for review August 21, 2025 15:47
@bridgekeeper
Copy link

bridgekeeper bot commented Aug 21, 2025

👋 Welcome back lmesnik! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Aug 21, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk
Copy link

openjdk bot commented Aug 21, 2025

@lmesnik The following labels will be automatically applied to this pull request:

  • hotspot
  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added serviceability serviceability-dev@openjdk.org hotspot hotspot-dev@openjdk.org rfr Pull request is ready for review labels Aug 21, 2025
@mlbridge
Copy link

mlbridge bot commented Aug 21, 2025

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot hotspot-dev@openjdk.org rfr Pull request is ready for review serviceability serviceability-dev@openjdk.org
Development

Successfully merging this pull request may close these issues.

1 participant