Skip to content

Conversation

artur-oracle
Copy link
Member

@artur-oracle artur-oracle commented Aug 21, 2025

JDK-8349583 implementation assumes that OpenJDK client always sends "signature_algorithms_cert" extension together with "signature_algorithms" extension. But we didn't account for jdk.tls.client.disableExtensions and jdk.tls.server.disableExtensions system properties which can disable producing "signature_algorithms_cert" extension. This is an issue similar to JDK-8355779 but on the extension producing side.

Per TLSv1.3 RFC:

If no "signature_algorithms_cert" extension is
present, then the "signature_algorithms" extension also applies to
signatures appearing in certificates.

Also making a few cosmetic changes to the existing code.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8365820: Apply certificate scope constraints to algorithms in "signature_algorithms" extension when "signature_algorithms_cert" extension is not being sent (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26887/head:pull/26887
$ git checkout pull/26887

Update a local copy of the PR:
$ git checkout pull/26887
$ git pull https://git.openjdk.org/jdk.git pull/26887/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26887

View PR using the GUI difftool:
$ git pr show -t 26887

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26887.diff

Using Webrev

Link to Webrev Comment

…ure_algorithms" extension when "signature_algorithms_cert" extension is not being sent
@bridgekeeper
Copy link

bridgekeeper bot commented Aug 21, 2025

👋 Welcome back abarashev! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Aug 21, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk
Copy link

openjdk bot commented Aug 21, 2025

@artur-oracle The following label will be automatically applied to this pull request:

  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added security security-dev@openjdk.org rfr Pull request is ready for review labels Aug 21, 2025
@mlbridge
Copy link

mlbridge bot commented Aug 21, 2025

Webrevs

@artur-oracle artur-oracle marked this pull request as draft August 22, 2025 14:37
@openjdk openjdk bot removed the rfr Pull request is ready for review label Aug 22, 2025
@artur-oracle artur-oracle marked this pull request as ready for review August 25, 2025 18:11
@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 25, 2025
@nibjen
Copy link
Contributor

nibjen commented Aug 26, 2025

Can a usecase be added for jdk.tls.server.disableExtensions if this option is being considered.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rfr Pull request is ready for review security security-dev@openjdk.org
Development

Successfully merging this pull request may close these issues.

2 participants