fix: protect DOMTimers until the ExecutingContext exits. #334
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
andycall
force-pushed
the
fix/protect_timers
branch
from
62b37e2 to
e8a9d62
Compare
zjt123
approved these changes
May 17, 2023
zjt123
approved these changes
May 17, 2023
hzbhzb
approved these changes
May 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some rare cases, DOMTimer may be accessed even if the timer has been canceled and removed from the DOMCoordinator. This could cause a BAD ACCESS crash since the timer's memory has been freed.
In this patch, we terminate the timer but do not immediately free it.