Don't use wrong weight when passivating group #17566
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sponsored by: Klara, Inc.; Wasabi Technology, Inc.
Motivation and Context
When we're passivating a metaslab group in ZFS, we start by passivating the metaslabs that have been activated for each of the allocators. To do that, we need to provide a weight. However, currently this erroneously always uses a segment-based weight, even if segment-based weighting is disabled.
Description
Use the normal weight function, which will decide which type of weight to use.
How Has This Been Tested?
Basic sanity testing, plus tests where I verified that on unload, the metaslab weights were space-based instead of segment-based when segment-based was disabled.
Types of changes
Checklist:
Signed-off-by
.