Fix invalid ConfigMap key translation

[zimnx]

Description of the change:

When generating ConfigMap keys from OLM bundle filenames, colons (:) were being replaced with tildes (~). However, ~ is not a valid character for ConfigMap keys, leading to errors like:

binaryData[scylladb~controller~aggregate-to-operator_rbac.authorization.k8s.io_v1_clusterrole.yaml]: Invalid value: "...": a valid config key must consist of alphanumeric characters, '-', '_' or '.' (regex: '[-._a-zA-Z0-9]+')

This commit fixes the issue by replacing : with hyphens (-) instead, which are allowed in ConfigMap keys. For example:

• Before: scylladb:controller:aggregate-to-operator... → scylladb~controller~aggregate-to-operator... (invalid)
• After: scylladb:controller:aggregate-to-operator... → scylladb-controller-aggregate-to-operator... (valid)

Motivation for the change:

This ensures all generated ConfigMap keys conform to Kubernetes naming requirements.

Reviewer Checklist

• Implementation matches the proposed design, or proposal is updated to match implementation
• Sufficient unit test coverage
• Sufficient end-to-end test coverage
• Docs updated or added to /docs
• Commit messages sensible and descriptive

Closes #1741

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign oceanc80 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

Hi @zimnx. Thanks for your PR.

I'm waiting for a operator-framework member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.