Skip to content

feat: updated for fsc git action #458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 12, 2022
Merged

feat: updated for fsc git action #458

merged 2 commits into from
Jul 12, 2022

Conversation

ozayr-zaviar
Copy link
Contributor

@ozayr-zaviar ozayr-zaviar commented Jun 28, 2022 •
edited
Loading

Summary

  • Git actions updated to run FSC on git actions.

Note

  • Need to change travisci-tools branch from mnoman/gitActions to master

@coveralls
Copy link

coveralls commented Jun 28, 2022 •
edited
Loading

Coverage Status

Coverage remained the same at 95.687% when pulling 004fefe on uzair/test-with-fsc into 47d0a05 on master.

@ozayr-zaviar ozayr-zaviar changed the title test: FSC git action feat: updated for fsc git action Jun 30, 2022
@msohailhussain msohailhussain marked this pull request as ready for review July 11, 2022 23:45
@msohailhussain msohailhussain requested a review from a team as a code owner July 11, 2022 23:45
msohailhussain
msohailhussain reviewed Jul 11, 2022
View reviewed changes
jaeopt
jaeopt requested changes Jul 12, 2022
View reviewed changes
Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a fix suggested

.github/workflows/swift.yml
@@ -26,7 +26,7 @@ jobs:

integration_tests:
if: "${{ github.event.inputs.PREP == '' && github.event.inputs.RELEASE == '' }}"
uses: optimizely/swift-sdk/.github/workflows/integration_tests.yml@master
uses: optimizely/swift-sdk/.github/workflows/integration_tests.yml@uzair/test-with-fsc
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here? should be @master ?

msohailhussain
msohailhussain approved these changes Jul 12, 2022
View reviewed changes
Copy link
Contributor

@msohailhussain msohailhussain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jaeopt jaeopt self-requested a review July 12, 2022 00:51
@jaeopt jaeopt merged commit 7a60c65 into master Jul 12, 2022
@jaeopt jaeopt deleted the uzair/test-with-fsc branch July 12, 2022 00:52
yasirfolio3 pushed a commit that referenced this pull request Mar 10, 2023
@ozayr-zaviar @yasirfolio3
feat: updated for fsc git action (#458)
d6b855d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msohailhussain msohailhussain msohailhussain approved these changes

@jaeopt jaeopt jaeopt approved these changes

Assignees

@ozayr-zaviar ozayr-zaviar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ozayr-zaviar @coveralls @msohailhussain @jaeopt