fix: catch defusedxml security errors #1138
Open
+83
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
tromai
reviewed
Aug 5, 2025
tromai
reviewed
Aug 5, 2025
tromai
approved these changes
Aug 5, 2025
nicallen
approved these changes
Aug 6, 2025
Signed-off-by: Ben Selwyn-Smith <benselwynsmith@googlemail.com>
Signed-off-by: Ben Selwyn-Smith <benselwynsmith@googlemail.com>
Signed-off-by: Ben Selwyn-Smith <benselwynsmith@googlemail.com>
benmss
force-pushed
the
benmss/fix-xml-parse-error
branch
from
1fa7ed6 to
5d1495e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes an uncaught exception that can be triggered by XML files with restricted content.
Description of changes
When searching for repositories for Maven projects, Macaron must parse the contents of the related POM files in the XML format. Use of the
defusedxmllibrary addresses the various security concerns this parsing involves, but the exceptions these cases can raise have not yet been accounted for.This PR makes a small adjustment to the
pomparsermodule, extending the catch clause to include thedefusedxmlsecurity related exceptions.A unit test has also been included with examples of valid and invalid XML files.