Fix handling of defaults in Header objects #2206
Merged
+25
−9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the handling of defaults passed to the
Headers
constructor. It now has uniform behavior with headers added withHeaders.add
This fix uses
Headers.extend
to add defaults as opposed toList.extend
used previously. Using the Headers' extend method allows all internal checks and conversions to be done on the default values passed.For an example, newlines are not allowed in headers.
Before this fix
h1
would get created whileh2
would fail. Now they would both fail.Checklist:
CHANGES.rst
summarizing the change and linking to the issue... versionchanged::
entries in any relevant code docs.pre-commit
hooks and fix any issues.pytest
andtox
, no tests failed.