Skip to content

Conversation

HundredVisionsGuy
Copy link

@HundredVisionsGuy HundredVisionsGuy commented May 2, 2022

Created new sansio/http module. The current top-level http module will invoke sansio/http with explicit argument

Checklist:

  • Add tests that demonstrate the correct behavior of the change. Tests should fail without the change.
  • Add or update relevant docs, in the docs folder and in code.
  • Add an entry in CHANGES.rst summarizing the change and linking to the issue.
  • Add .. versionchanged:: entries in any relevant code docs.
  • Run pre-commit hooks and fix any issues.
  • Run pytest and tox, no tests failed.

@davidism davidism changed the base branch from 2.1.x to main May 2, 2022 20:35
@HundredVisionsGuy HundredVisionsGuy marked this pull request as ready for review May 2, 2022 23:43
Copy link
Member

@pgjones pgjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should squash the commits into one.

@rrahkola
Copy link
Contributor

We squashed the commits as requested, but the check for "Tests/3.11-dev" failed three tests. Looking at the test result, we don't understand how our code would cause these failures. Maybe these failures are related to #2421 ?

Could you please advise?

@pgjones pgjones merged commit b42d1a4 into pallets:main Jul 22, 2022
@davidism davidism added this to the 2.2.0 milestone Jul 22, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refactor WSGI assumptions out of http.py and wsgi.py functions
4 participants