Lowercase the parsed options names #2442
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I need to finish this - before then I want to check we are happy with an addition datastructure |
|
Referencing ASGI django/asgiref#246 (comment), incoming headers (and options) should be lowercased. I don't think it's worth adding a whole new datastructure (and it's missing at least |
pgjones
changed the title
I cannot find a RFC that indicates that the option names are case sensitive whereas RFC6266 states that the `filename` option name is case insensitive. Therefore the best user experience is to lowercase the names. This will cause breaking changes if case sensitivity is relied upon, and hence users will need to use the lowercase name if so.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I cannot find a RFC that indicates that the option names are case
sensitive whereas RFC6266 states that the
filenameoption name iscase insensitive. Therefore the best user experience is to lowercase
the names.
This will cause breaking changes if case sensitivity is relied upon,
and hence users will need to use the lowercase name if so.
closes #2422
Checklist:
CHANGES.rstsummarizing the change and linking to the issue... versionchanged::entries in any relevant code docs.pre-commithooks and fix any issues.pytestandtox, no tests failed.