fix: version parsing in scripts/publish.sh
#1556
Merged
+1
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ok, cool basically the issue is that we All good thanks for spotting this. |
niklasad1
approved these changes
Apr 21, 2025
|
@mdqst bonus in this PR would be to remove https://github.com/paritytech/jsonrpsee/blob/master/scripts/publish.sh#L9 as well :) |
niklasad1 fixed. now you can merge it. thanks! |
niklasad1
approved these changes
Apr 21, 2025
niklasad1
changed the title
scripts/publish.sh
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the
read_tomlfunction always read the version from the rootCargo.toml, regardless of the current crate being processed in the loop. This was due to referencing$DIR/Cargo.toml, which pointed to the original working directory beforecdinto the sub-crate.Switched to using
./Cargo.tomlto correctly read the version from each crate's localCargo.toml.Now it properly fetches the version for each submodule instead of reusing the root version.