OUIA audit #4401
Merged
OUIA audit #4401
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
16 tasks
|
PF4 preview: https://patternfly-react-pr-4401.surge.sh |
psav
force-pushed
the
ouiaattrs
branch
18 times, most recently
from
12923d7 to
d9b04b0
Compare
psav
commented
Jun 19, 2020
packages/react-core/src/components/AlertGroup/__tests__/__snapshots__/AlertGroup.test.tsx.snap
Show resolved
Hide resolved
psav
commented
Jun 19, 2020
...src/components/ApplicationLauncher/__tests__/__snapshots__/ApplicationLauncher.test.tsx.snap
Show resolved
Hide resolved
psav
commented
Jun 19, 2020
...src/components/ApplicationLauncher/__tests__/__snapshots__/ApplicationLauncher.test.tsx.snap
Outdated
Show resolved
Hide resolved
packages/react-core/src/components/Nav/__tests__/__snapshots__/Nav.test.tsx.snap
Show resolved
Hide resolved
packages/react-core/src/components/Pagination/__tests__/__snapshots__/Pagination.test.tsx.snap
Outdated
Show resolved
Hide resolved
packages/react-core/src/components/Pagination/__tests__/__snapshots__/Pagination.test.tsx.snap
Show resolved
Hide resolved
dlabrecq
previously approved these changes
Jun 19, 2020
redallen
suggested changes
Jun 22, 2020
psav
force-pushed
the
ouiaattrs
branch
2 times, most recently
from
7a88885 to
3329e1b
Compare
redallen
suggested changes
Jun 22, 2020
packages/react-core/src/components/ApplicationLauncher/ApplicationLauncher.tsx
Show resolved
Hide resolved
dlabrecq
approved these changes
Jun 22, 2020
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Standardizes OUIA implementations and adds extra attrs for documentation linkage
Closes several pieces in #4400