Make pg_basebackup work with encrypted WAL #473
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dutow
reviewed
Jul 28, 2025
| { | ||
| #ifdef PERCONA_EXT | ||
| /* | ||
| * Don't rewrite WAL keys and providers. User may have different |
There was a problem hiding this comment.
I don't think this is a good idea: this also skips the providers file, which contains the global providers.
Global providers are also used without wal encryption, so in this regard, this is a breaking change.
Also, this can result in the server unable to start up, if it tries to do recovery on an encrypted table, as it can't load the keys.
If we only skip the keys file, startup after backup seems to work consistently.
When WAL is streamed during the backup (default mode), it comes in unencrypted. But we need keys to encrypt it. For now, we expect that the user would put `pg_tde` dir containing the `1664_key` and `1664_providers` into the destination directory before starting the backup. And we encrypt streamed WAL according to the internal keys. No `pg_tde` dir means no streamed WAL encryption.
As it may clash with encrypted WAL streaming. Hide the fetch option from the usage output and throw an error if it is used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP, needs TAP tests