PG-1411 Make pg_resetwal work with TDE #476
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dAdAbird
reviewed
Jul 21, 2025
artemgavrilov
force-pushed
the
PG-1411-pg_resetwal
branch
2 times, most recently
from
f29751d to
763b096
Compare
dutow
reviewed
Jul 28, 2025
artemgavrilov
force-pushed
the
PG-1411-pg_resetwal
branch
from
763b096 to
575fe0e
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project status has failed because the head coverage (81.78%) is below the target coverage (90.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## TDE_REL_17_STABLE #476 +/- ##
=====================================================
+ Coverage 81.75% 81.78% +0.03%
=====================================================
Files 24 24
Lines 2987 2987
Branches 485 485
=====================================================
+ Hits 2442 2443 +1
+ Misses 444 443 -1
Partials 101 101
🚀 New features to boost your workflow:
|
dAdAbird
reviewed
Jul 30, 2025
artemgavrilov
force-pushed
the
PG-1411-pg_resetwal
branch
2 times, most recently
from
2e51b72 to
7b5e387
Compare
dAdAbird
reviewed
Jul 30, 2025
As pg_resetwal removes old WAL segments and creates new one with empty record we can do that write in unencrypted mode. However that requires new WAL key creation in case if encryption was enabled before.
These tests are copy of original pg_resetwal tests with enalbed WAL encryption and removed flags validation as we interested here only in proper enrypted WAL handling.
artemgavrilov
force-pushed
the
PG-1411-pg_resetwal
branch
from
7b5e387 to
d70f2c9
Compare
dAdAbird
approved these changes
Jul 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://perconadev.atlassian.net/browse/PG-1411
The only thing that differs in pg_resetwal for TDE setups is that it performs WAL key rotation the same way as server itself on startup. During this rotation pg_resetwal always create
unecryptedtype of key as WAL will contain only one record that don't contain anything sensitive. So no need actually encrypt anything yet. On startup server will create new key with proper type.