-
Notifications
You must be signed in to change notification settings - Fork 11
PG-1523 Rework uninstallation documentation cleanup #490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: TDE_REL_17_STABLE
Are you sure you want to change the base?
Conversation
This commit rearranges the uninstallation documentation and adds instructions for disabling WAL encryption.
To proceed, you must have one of the following privileges: | ||
|
||
- Superuser privileges (to remove the extension globally), or | ||
- Database owner privileges (to remove it from a specific database only) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure what this adds. Under most circumstances you need to be superuser and to me it is so extremely obvious.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is mostly to ensure that new users are aware of the necessary admin privileges, I am trying to include, going forward, as much information as possible for all types of users. Sometimes, some information that seems repeating or redundant would still be appreciated for some users.
Let me know your thoughts. :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do you have ()? Without them, it reads exactly the same
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I used the () to explain a bit why privileges are required, I could also use commas but I feel these pop out better when reading them
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMHO, the text without brackets explains the same information as well as with them:) But () make it heavier. Up to you, though
To proceed, you must have one of the following privileges: | ||
|
||
- Superuser privileges (to remove the extension globally), or | ||
- Database owner privileges (to remove it from a specific database only) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do you have ()? Without them, it reads exactly the same
This commit cleans up the uninstallation documentation.