give to admins full power of regex #701
Conversation
btry
force-pushed
the
feature/506_more_regex_power
branch
3 times, most recently
from
9dab34b to
9043027
Compare
btry
force-pushed
the
feature/506_more_regex_power
branch
from
9043027 to
d266059
Compare
install/update_2.5_2.6.php
Outdated
|
|
||
| if (!$isValid) { | ||
| // The regex is invalid (likely not updated yet) | ||
| $updatedRegex = addslashes('/^' . $row['regex'] . '$/'); |
There was a problem hiding this comment.
according to this part https://github.com/pluginsGLPI/formcreator/pull/701/files#diff-bc7cf4201f52932596eb92080c6e915aL406
it seems the previous behavior was a little bit more complex.
We can have these case:
- no prefix
- prefix
/ - prefix
/^
same with suffix.
There was a problem hiding this comment.
When an admin adds a regex validation, the previous behavior is to detect if the regex has delimiters and anchors. If one of them was missing, then the plugin added them automatically before saving.
So, thee regexes in DB in versions up to 2.5.x always start with "/^" and ends "$/".
Actually, your comment makes me realize this upgrade code is useless. I need to remove it.
There was a problem hiding this comment.
By the way, as the upgrade becomes empty, I can revert the upgrade code I took from an other PR. This will avoid useless merge conflicts
There was a problem hiding this comment.
ok let me know when i need to recheck
see #506 : need more power for admins with regex validation.