Skip to content

Make the whole package set available #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 26, 2020
Merged

Make the whole package set available #173

merged 3 commits into from
May 26, 2020

Conversation

hdgarrood
Copy link
Collaborator

Resolves #154. On my machine locally, with the RTS flags in
deploy/start, the resident memory seems to sit fairly stable around
1.89G, which is encouraging. I've tweaked the RTS flags slightly in
order to make better use of the resized droplet, which has 4GB memory
and 2 virtual CPU cores.

Resolves #154. On my machine locally, with the RTS flags in
`deploy/start`, the resident memory seems to sit fairly stable around
1.89G, which is encouraging. I've tweaked the RTS flags slightly in
order to make better use of the resized droplet, which has 4GB memory
and 2 virtual CPU cores.
@natefaubion
Copy link
Contributor

Can we confirm what happens when you try to use a foreign library that we have not shimmed? I honestly have no idea!

@hdgarrood
Copy link
Collaborator Author

You get an error in the console, like this:
Screenshot from 2020-05-21 21-01-32

@hdgarrood
Copy link
Collaborator Author

I'll add the shim for big-integer. Can people think of others we're missing?

@natefaubion
Copy link
Contributor

Do we need to update the react version?

@thomashoneyman
Copy link
Member

React is on 16.13.1 and the shim here is on 16.13.0, so it’s possible to update but the version is pretty current.

@thomashoneyman
Copy link
Member

I took a breeze through the package set and the only other libraries that stand out:

There are some Node, Redis, etc. libraries in here too, but they don't really make sense for Try PureScript anyway.

@thomashoneyman
Copy link
Member

I've upped the React patch version, and I've added the uuid and decimal.js packages to the shims. If any others crop up in the future we can always add them later on.

, deps: []
}
, Tuple "uuid"
{ url: "https://cdnjs.cloudflare.com/ajax/libs/uuid/8.1.0/uuid.min.js"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's nothing on unpkg for this package, but it does exist on Cloudflare.

@hdgarrood hdgarrood merged commit 043732f into master May 26, 2020
@hdgarrood hdgarrood deleted the entire-package-set branch May 26, 2020 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support loading/unloading of externs as needed on the server.
4 participants