Update package set for PureScript 0.14 #213
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomashoneyman
commented
Mar 27, 2021
| @@ -2,6 +2,7 @@ | |||
| {-# LANGUAGE DeriveGeneric #-} | |||
| {-# LANGUAGE LambdaCase #-} | |||
| {-# LANGUAGE OverloadedStrings #-} | |||
| {-# LANGUAGE PatternGuards #-} | |||
There was a problem hiding this comment.
CI fails otherwise.
|
Just a thought. Could we not install the node libraries since they won't be
used anyway?
|
|
We could blocklist libraries we don’t want to include, certainly. But if we can afford to keep libraries I think we should, even if it’s just so folks can share example code (even if it doesn’t run, it at least compiles). |
hdgarrood
approved these changes
Mar 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #205 by updating to a 0.14 package set. This package set should be a decrease in memory load because it's smaller than the later 0.13.x package sets (like the one currently running on Try PureScript). It's also necessary to update the package set to 0.14 before deploying a new version of Try PureScript using the 0.14 compiler.