Skip to content

Update trypurescript deps to match purescript repo versions #223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 29, 2021
Merged

Update trypurescript deps to match purescript repo versions #223

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
5bf614d
Update trypurescript server PS dep to v0.14.1
JordanMartinez May 28, 2021
6579055
Update to lts-17.6 and remove unneeded deps
JordanMartinez May 28, 2021
51de215
Update versioned deps in trypurescript.cabal to match purescript.cabal
JordanMartinez May 28, 2021
53b6018
Pin scotty and warp to lts-17.6 versions
JordanMartinez May 28, 2021
d7d4393
Set all dependencies to `-any` and clarify why
JordanMartinez May 28, 2021
1a7cf3c
Fix typo
JordanMartinez May 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 5 additions & 13 deletions stack.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,22 +1,14 @@
resolver: lts-13.26
resolver: lts-17.6
flags:
aeson-pretty:
lib-only: true
these:
assoc: false
quickcheck: false
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to keep this in? It lets us avoid depending on quickcheck.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like it's an invalid flag. If I run stack build with that included, I get this error:

$ stack build
Invalid flag specification:
- Package 'these' does not define the following flags (specified in stack.yaml):
  quickcheck
- Flags defined by package 'these':
  these:assoc

Note: PureScript's stack.yaml file doesn't have that flag either.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh right ok sorry, I didn’t realise it had been removed.

packages:
- '.'
extra-deps:
# purescript 0.14.0-rc5
- github: purescript/purescript
commit: 7ecc42669c69682996f2196ba2eef6c4ca827348
subdirs:
- .
- lib/purescript-ast
- lib/purescript-cst
- happy-1.19.9
- purescript-0.14.1
- purescript-ast-0.1.1.0
- purescript-cst-0.1.1.0
- happy-1.20.0
- language-javascript-0.7.0.0
- network-3.0.1.1
- these-1.0.1
- semialign-1
10 changes: 5 additions & 5 deletions trypurescript.cabal
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,21 +15,21 @@ data-dir: ""
executable trypurescript
build-depends: base ==4.*,
aeson -any,
bytestring >=0.10.0.2 && <0.11,
bytestring >=0.10.12.0 && <0.11,
data-default -any,
directory -any,
filepath -any,
Glob -any,
scotty -any,
scotty ==0.12,
purescript,
purescript-cst,
containers -any,
http-types >= 0.8.5,
Copy link
Contributor Author

@JordanMartinez JordanMartinez May 28, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hdgarrood Before I merge this, should http-types be updated to -any or to the lts-17.6 package set's version, which is 0.12.3?

And is it correct that -any will use whichever dependencies work with purescript and the other versions dependencies? I'm not familiar with this syntax unfortunately.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thinking about this a little more I think we might as well use -any for all of the dependencies here. This project is only ever going to be built by stack, and the stack.yaml file already pins everything down to a specific version, so additionally specifying versions here doesn’t really add anything.

It’s more important to provide accurate version bounds when you’re making a library which other people are depending on - this part of the cabal file does the same job as the dependencies part of a bower.json or package.json file in a JS library. But that’s not what we are doing here so it doesn’t really matter.

transformers ==0.5.*,
mtl ==2.2.2,
transformers >=0.5.6.2 && <0.6,
mtl >=2.2.2 && <2.3,
text -any,
time -any,
warp -any
warp ==3.3.14
hs-source-dirs: server
main-is: Main.hs
buildable: True
Expand Down