Update invalid-envvar-default to flag os.environ.get

[Aearsears]

Type of Changes

	Type
✓	🐛 Bug fix
	✨ New feature
	🔨 Refactoring
	📜 Docs

Description

This PR updates the StdLibchecker to check for invalid-envvar-default and invalid-envvar-value when calling os.environ.get. os.environ is a mapping object and it calls concretely builtins.dict 's get method

Relates to PR #10094

Closes #10092

[Aearsears]

should I create a news fragment for this change?

[Pierre-Sassoulas]

Yes, indeed :) thank you for the MR, I skimmed and i've seen nothing shocking, will review in depth later. Great first contribution !

[github-actions]

🤖 Effect of this PR on checked open source code: 🤖

Effect on home-assistant:
The following messages are now emitted:

1. invalid-envvar-default:
   os.environ.get default type is builtins.int. Expected str or None.
   https://github.com/home-assistant/core/blob/15505cdd56f860e21155474f8bd92c044411cb69/homeassistant/util/resource.py#L20

Effect on black:
The following messages are now emitted:

1. invalid-envvar-default:
   os.environ.get default type is builtins.int. Expected str or None.
   https://github.com/psf/black/blob/abd5f08107b09f768b1ec98c7a48e65ec7fdd661/src/black/concurrency.py#L86

Effect on django:
The following messages are now emitted:

1. invalid-envvar-default:
   os.environ.get default type is builtins.int. Expected str or None.
   https://github.com/django/django/blob/ad4a9e0f3b1de261409bc083aa49dba705531824/django/utils/autoreload.py#L434

Effect on sentry:
The following messages are now emitted:

1. invalid-envvar-default:
   os.environ.get default type is builtins.bool. Expected str or None.
   https://github.com/getsentry/sentry/blob/9ed4ed8c78e6163eb443023a05ef37b3739cb82a/src/sentry/conf/server.py#L735
2. invalid-envvar-default:
   os.environ.get default type is builtins.bool. Expected str or None.
   https://github.com/getsentry/sentry/blob/9ed4ed8c78e6163eb443023a05ef37b3739cb82a/src/sentry/conf/server.py#L1971
3. invalid-envvar-default:
   os.environ.get default type is builtins.bool. Expected str or None.
   https://github.com/getsentry/sentry/blob/9ed4ed8c78e6163eb443023a05ef37b3739cb82a/src/sentry/conf/server.py#L2983
4. invalid-envvar-default:
   os.environ.get default type is builtins.bool. Expected str or None.
   https://github.com/getsentry/sentry/blob/9ed4ed8c78e6163eb443023a05ef37b3739cb82a/src/sentry/conf/server.py#L3023
5. invalid-envvar-default:
   os.environ.get default type is builtins.bool. Expected str or None.
   https://github.com/getsentry/sentry/blob/9ed4ed8c78e6163eb443023a05ef37b3739cb82a/src/sentry/conf/server.py#L3140
6. invalid-envvar-default:
   os.environ.get default type is builtins.bool. Expected str or None.
   https://github.com/getsentry/sentry/blob/9ed4ed8c78e6163eb443023a05ef37b3739cb82a/src/sentry/conf/server.py#L3885
7. invalid-envvar-default:
   os.environ.get default type is builtins.bool. Expected str or None.
   https://github.com/getsentry/sentry/blob/9ed4ed8c78e6163eb443023a05ef37b3739cb82a/src/sentry/apidocs/utils.py#L74
8. invalid-envvar-default:
   os.environ.get default type is builtins.bool. Expected str or None.
   https://github.com/getsentry/sentry/blob/9ed4ed8c78e6163eb443023a05ef37b3739cb82a/src/sentry/runner/settings.py#L129
9. invalid-envvar-default:
   os.environ.get default type is builtins.int. Expected str or None.
   https://github.com/getsentry/sentry/blob/9ed4ed8c78e6163eb443023a05ef37b3739cb82a/src/sentry/testutils/pytest/sentry.py#L403
10. invalid-envvar-default:
    os.environ.get default type is builtins.int. Expected str or None.
    https://github.com/getsentry/sentry/blob/9ed4ed8c78e6163eb443023a05ef37b3739cb82a/src/sentry/testutils/pytest/sentry.py#L404

This comment was generated for commit 5f36561

[Pierre-Sassoulas]

Seeing the messages in the primer, we should probably not raise for int(os.get.environ("SOMETHING", 1) or float(os.get.environ("SOMETHING", 1.0), but let's remember that it's the work of a type checker to warn about this not pylint, and type checkers exists. (Don't want to discourage you, and you did great work, but they are more value in fixing other checks and other bugs in the backlog)

[Aearsears]

thanks for the review Pierre-Sassoulas, i'll see if I can find a quick solution to what you mentioned, otherwise i'll close this pr and contribute to other issues as you suggested