-
Notifications
You must be signed in to change notification settings - Fork 239
Parallel node setup v2 #1230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sshane
wants to merge
10
commits into
pytest-dev:master
Choose a base branch
from
sshane:parallel-node-setup-try2
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Parallel node setup v2 #1230
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
b43b009
clean
sshane f8b3f5e
fix acceptance_test
sshane 82f215e
fix everything
sshane 23f52e9
clean up
sshane f49c64d
moree
sshane 65d1c12
fix
sshane 01e30d9
hacky
sshane fc7e83d
fix
sshane f89edf9
clean up
sshane ba07d6b
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -82,11 +82,15 @@ def test_popen_makegateway_events( | |
call = hookrecorder.popcall("pytest_xdist_setupnodes") | ||
assert len(call.specs) == 2 | ||
|
||
call = hookrecorder.popcall("pytest_xdist_newgateway") | ||
assert call.gateway.spec == execnet.XSpec("execmodel=main_thread_only//popen") | ||
assert call.gateway.id == "gw0" | ||
call = hookrecorder.popcall("pytest_xdist_newgateway") | ||
assert call.gateway.id == "gw1" | ||
# check expected gateways | ||
gw_calls = [ | ||
hookrecorder.popcall("pytest_xdist_newgateway"), | ||
hookrecorder.popcall("pytest_xdist_newgateway"), | ||
Comment on lines
+87
to
+88
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We can also sort the |
||
] | ||
assert {c.gateway.id for c in gw_calls} == {"gw0", "gw1"} | ||
assert {c.gateway.spec for c in gw_calls} == { | ||
execnet.XSpec("execmodel=main_thread_only//popen") | ||
} | ||
assert len(hm.group) == 2 | ||
hm.teardown_nodes() | ||
assert not len(hm.group) | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
None of the other schedulers need this to pass tests, is this intentional?