Remove --new-type-inference flag #19570
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
sterliakov
reviewed
Aug 3, 2025
| @@ -391,10 +391,8 @@ def __init__(self) -> None: | |||
| # skip most errors after this many messages have been reported. | |||
| # -1 means unlimited. | |||
| self.many_errors_threshold = defaults.MANY_ERRORS_THRESHOLD | |||
| # Disable new experimental type inference algorithm. | |||
| # Disable new type inference algorithm. | |||
| self.old_type_inference = False | |||
There was a problem hiding this comment.
Do we still need this one? There are only a couple of use sites remaining, maybe just axe them here?
There was a problem hiding this comment.
Yeah, no, I think we may keep it for a while more (just in case), since it is not a no-op, unlike --new-type-inference.
hauntsaninja
approved these changes
Aug 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was on deprecated almost two years ago (it is on by default).