Skip to content

[FX] Changes done internally at Facebook #1288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 19, 2022
Merged

[FX] Changes done internally at Facebook #1288

merged 1 commit into from
Aug 19, 2022

Conversation

frank-wei
Copy link
Contributor

bd46e8f292bf68fe6b87d2d5d206c89fda79a746 Shirong Wu shirong@fb.com Disable group ln fuse pass
6ce1d3bc19d75b266e99355c96daeff7054dcbf8 Wei Wei wwei6@fb.com [fx2trt] set logging level to INFO at fx root
9d552dc3f69db9e4a249f80ef00803a9413e5d38 Wei Wei wwei6@fb.com [fx2trt] change OSS method lower_to_trt() to compile()

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant and/or add your own.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

Changes done internally at Facebook
bb5a238 
bd46e8f292bf68fe6b87d2d5d206c89fda79a746 Shirong Wu <shirong@fb.com> Disable group ln fuse pass
6ce1d3bc19d75b266e99355c96daeff7054dcbf8 Wei Wei <wwei6@fb.com> [fx2trt] set logging level to INFO at fx root
9d552dc3f69db9e4a249f80ef00803a9413e5d38 Wei Wei <wwei6@fb.com> [fx2trt] change OSS method lower_to_trt() to compile()
3ca2c554b12e60a32a4bd7f4cc54181920e43b19 wwei6 <wwei6@fb.com> [ads] sequential linear fuse
074aaa50123ef5512fd9b3f66a9c1b41b5931444 wwei6 <wwei6@fb.com> temp
d66aab69c3e3f506decfc18526e0980a3330cbee wwei6 <wwei6@fb.com> [ads] sequential linear fuse
@github-actions github-actions bot added component: api [Python] Issues re: Python API component: fx documentation Improvements or additions to documentation labels Aug 18, 2022
github-actions[bot]
github-actions bot approved these changes Aug 18, 2022
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to Python style guidelines

github-actions[bot]
github-actions bot approved these changes Aug 18, 2022
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

@narendasan
Copy link
Collaborator

Does this need to be part of 1.2.0?

narendasan
narendasan approved these changes Aug 19, 2022
View reviewed changes
Copy link
Collaborator

@narendasan narendasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@frank-wei
Copy link
Contributor Author

Does this need to be part of 1.2.0?

yes, I will cherry-pick it to 1.2.0 branch.

@frank-wei frank-wei merged commit b6b690c into master Aug 19, 2022
@frank-wei frank-wei deleted the fb-sync-wwei6 branch August 19, 2022 01:10
frank-wei pushed a commit that referenced this pull request Aug 19, 2022
Changes done internally at Facebook (#1288)
19ae4cb 
bd46e8f292bf68fe6b87d2d5d206c89fda79a746 Shirong Wu <shirong@fb.com> Disable group ln fuse pass
6ce1d3bc19d75b266e99355c96daeff7054dcbf8 Wei Wei <wwei6@fb.com> [fx2trt] set logging level to INFO at fx root
9d552dc3f69db9e4a249f80ef00803a9413e5d38 Wei Wei <wwei6@fb.com> [fx2trt] change OSS method lower_to_trt() to compile()


Co-authored-by: wwei6 <wwei6@devgpu001.nao2.facebook.com>
narendasan added a commit that referenced this pull request Aug 23, 2022
@narendasan @mfeliz-cruise
@dependabot @bowang007 @andi4191 @peri044
Update release branch (#1300)
143901f 
* feat: Jetson specific workspace file

Signed-off-by: Naren Dasan <naren@narendasan.com>
Signed-off-by: Naren Dasan <narens@nvidia.com>

* docs: Update jetson instructions

Signed-off-by: Naren Dasan <naren@narendasan.com>
Signed-off-by: Naren Dasan <narens@nvidia.com>

* docs: Update docgen task to not require a special container

Signed-off-by: Naren Dasan <naren@narendasan.com>
Signed-off-by: Naren Dasan <narens@nvidia.com>

* Checkpoint, initial test and implementation

* Fix error in layer conversion caused by zero/ones tensors of wrong type

* Sort input values in registerSegmentsOutputs to resolve nondeterminism

* lint

* lint

* feat: Add support for aten::square

* chore(deps): bump @actions/core in /.github/actions/assigner

Bumps [@actions/core](https://github.com/actions/toolkit/tree/HEAD/packages/core) from 1.8.2 to 1.9.1.
- [Release notes](https://github.com/actions/toolkit/releases)
- [Changelog](https://github.com/actions/toolkit/blob/main/packages/core/RELEASES.md)
- [Commits](https://github.com/actions/toolkit/commits/HEAD/packages/core)

---
updated-dependencies:
- dependency-name: "@actions/core"
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>

* fix: fix misleading skipping partitioning msg

Signed-off-by: Bo Wang <bowa@nvidia.com>

* Changes done internally at Facebook (#1288)

bd46e8f292bf68fe6b87d2d5d206c89fda79a746 Shirong Wu <shirong@fb.com> Disable group ln fuse pass
6ce1d3bc19d75b266e99355c96daeff7054dcbf8 Wei Wei <wwei6@fb.com> [fx2trt] set logging level to INFO at fx root
9d552dc3f69db9e4a249f80ef00803a9413e5d38 Wei Wei <wwei6@fb.com> [fx2trt] change OSS method lower_to_trt() to compile()


Co-authored-by: wwei6 <wwei6@devgpu001.nao2.facebook.com>

* chore: Truncate long and double for ptq CPP path

Signed-off-by: Anurag Dixit <a.dixit91@gmail.com>

* chore: Fix dataloader in finetune_qat script

Signed-off-by: Anurag Dixit <a.dixit91@gmail.com>

* docs: Update docgen task

Signed-off-by: Naren Dasan <naren@narendasan.com>
Signed-off-by: Naren Dasan <narens@nvidia.com>

* chore: apply linting

Signed-off-by: Naren Dasan <naren@narendasan.com>
Signed-off-by: Naren Dasan <narens@nvidia.com>

* Update docgen.yml

* Update docgen.yml

* Update docgen.yml

* Update docgen.yml

* Update docgen.yml

* Update docgen.yml

* Update docgen.yml

* update fx notebook (#1297)

* Changes done internally at Facebook (#1299)

bd46e8f292bf68fe6b87d2d5d206c89fda79a746 Shirong Wu <shirong@fb.com> Disable group ln fuse pass
6ce1d3bc19d75b266e99355c96daeff7054dcbf8 Wei Wei <wwei6@fb.com> [fx2trt] set logging level to INFO at fx root
9d552dc3f69db9e4a249f80ef00803a9413e5d38 Wei Wei <wwei6@fb.com> [fx2trt] change OSS method lower_to_trt() to compile()
6c4bdb8ac5823d161e4afc7c9d295f961aeeb0bf Mor Tzur <mortzur@fb.com> fix engine holder test binary to fix  contbuild_pytorch_fx2trt_build
636d0ab2a3d0f09267e25b8b8e7eedd4d91d791d Yinghai Lu <yinghai@fb.com> [easy] remove random prints
5a97668307c26e69a89a4e02a535e319eaf3ce3d Wei Wei <wwei6@fb.com> [ads] sequential linear fuse
508338ab343e407ee49605919508210b62ad9a52 Wei Wei <wwei6@fb.com> [fx2trt] minor literal fix

* Update docgen.yml

* Update docgen.yml

* Update docgen.yml

* Update docgen.yml

* docs: [Automated] Regenerating documenation for 0baf50a

Signed-off-by: Torch-TensorRT Github Bot <torch-tensorrt.github.bot@nvidia.com>

* fix(tools): Fix linter to not depend on docker (#1301) (#1302)

* fix(tools): Fix linter to not depend on docker

Signed-off-by: Naren Dasan <1790613+narendasan@users.noreply.github.com>

* Update linter.yml

* Update linter.yml

Signed-off-by: Naren Dasan <1790613+narendasan@users.noreply.github.com>

Signed-off-by: Naren Dasan <1790613+narendasan@users.noreply.github.com>

Signed-off-by: Naren Dasan <naren@narendasan.com>
Signed-off-by: Naren Dasan <narens@nvidia.com>
Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: Bo Wang <bowa@nvidia.com>
Signed-off-by: Anurag Dixit <a.dixit91@gmail.com>
Signed-off-by: Torch-TensorRT Github Bot <torch-tensorrt.github.bot@nvidia.com>
Signed-off-by: Naren Dasan <1790613+narendasan@users.noreply.github.com>
Co-authored-by: Michael Feliz <michael.feliz@getcruise.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Bo Wang <bowa@nvidia.com>
Co-authored-by: Wei <wwei6@fb.com>
Co-authored-by: wwei6 <wwei6@devgpu001.nao2.facebook.com>
Co-authored-by: Anurag Dixit <a.dixit91@gmail.com>
Co-authored-by: Dheeraj Peri <peri.dheeraj@gmail.com>
Co-authored-by: Bo Wang <33285888+bowang007@users.noreply.github.com>
Co-authored-by: Torch-TensorRT Github Bot <torch-tensorrt.github.bot@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@narendasan narendasan narendasan approved these changes

@github-actions github-actions[bot] github-actions[bot] approved these changes

@842974287 842974287 Awaiting requested review from 842974287

@wushirong wushirong Awaiting requested review from wushirong

+1 more reviewer

@yinghai yinghai yinghai approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
cla signed component: api [Python] Issues re: Python API component: fx documentation Improvements or additions to documentation fx
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@frank-wei @narendasan @yinghai @facebook-github-bot