Skip to content

Conversation

Njuapp
Copy link
Contributor

@Njuapp Njuapp commented Nov 9, 2022

Description

Use scalar_to_tensor as much as possible in element_wise.cpp to avoid scalar.to<float>() which aggressively casts scalar to float. All tests passed.

Fixes #1447

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

@github-actions github-actions bot added component: conversion Issues re: Conversion stage component: converters Issues re: Specific op converters component: core Issues re: The core compiler labels Nov 9, 2022
Copy link
Collaborator

@peri044 peri044 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@peri044 peri044 merged commit cde5e55 into pytorch:master Nov 10, 2022
@Njuapp Njuapp deleted the scalar_to_tensor branch November 14, 2022 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla signed component: conversion Issues re: Conversion stage component: converters Issues re: Specific op converters component: core Issues re: The core compiler
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 [Bug] Some elementwise like floor_divide.Scalar using float as default scalar type
3 participants