Skip to content

Remove libtorio #4035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 56 commits into from
Aug 21, 2025
Merged

Remove libtorio #4035

merged 56 commits into from
Aug 21, 2025

Conversation

samanklesaria
Copy link
Collaborator

This removes the deprecated libtorio components of torchaudio

Copy link

pytorch-bot bot commented Aug 11, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/audio/4035

Note: Links to docs will display an error until the docs builds have been completed.

❌ 8 New Failures

As of commit 4533e1f with merge base a645da6 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed label Aug 11, 2025
@samanklesaria
Copy link
Collaborator Author

This is a bigger chunk than I realized. The right thing to do is probably to remove the AudioEffector first, followed by other smaller pieces.

@samanklesaria samanklesaria changed the base branch from main to remove_ffmpeg_util August 19, 2025 17:45
@samanklesaria samanklesaria marked this pull request as ready for review August 19, 2025 22:40
@samanklesaria samanklesaria requested a review from a team as a code owner August 19, 2025 22:40
@samanklesaria samanklesaria merged commit 160c265 into remove_ffmpeg_util Aug 21, 2025
40 of 41 checks passed
@samanklesaria samanklesaria deleted the remove_libtorio branch August 21, 2025 14:00
@samanklesaria
Copy link
Collaborator Author

Whoops! I forgot that the base of this branch wasn't main. I'll do the ffmpeg one first.

@samanklesaria samanklesaria restored the remove_libtorio branch August 21, 2025 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants