-
Notifications
You must be signed in to change notification settings - Fork 714
Remove prototype files #4048
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: remove_torio_docs
Are you sure you want to change the base?
Remove prototype files #4048
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/audio/4048
Note: Links to docs will display an error until the docs builds have been completed. ❌ 8 New FailuresAs of commit 370ad64 with merge base a645da6 ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
@@ -1,107 +0,0 @@ | |||
#!/usr/bin/env python3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's not touch the examples folder for now. It would require more work. For example this pipeline_demo.py file is mentioned in the README, so removing it would mean updating the readme. We'll do that as follow-ups
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This example used functionality from the prototype files, which is why I included it here. If you like, I can do a separate PR for the examples first, before merging this one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or should I just update the readme for this single demo first?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approving to unblock but please see other comments
As written elsewhere in the PR, I changed the target to be the |
This PR removes the prototype directory from
src
along with prototype references indocs
. It currently depends on, and should be merged after, the CUTC wrapper removal PR, because sphinx now breaks on our deprecation-wrapped classes. Specifically, we get the docs build error:This suggests that if we just merged the CUTC PR first, this error would go away. Note that this error does not show up in the CI: the CI logs for sphinx only show the exit code and suppress all other output.