Skip to content

[STABLE ABI] Port lfilter to stable ABI #4060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 9 commits into
base: pseudo_main
Choose a base branch
from

Conversation

samanklesaria
Copy link
Collaborator

@samanklesaria samanklesaria commented Aug 20, 2025

This PR ports lfilter to the stable ABI. The c++ generic interface (for non-cpu and non-cuda devices) is temporarily removed, an will be added back in python for now. The code still uses parallel_for for now. Although the code currently works off of the stable_accesor and pseudo_main branch (incorporating those commits), it can be rebased to depend only on main if necessary.
Currently, this PR only includes the CPU kernel. It will eventually contain both cpu and cuda kernels.

Copy link

pytorch-bot bot commented Aug 20, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/audio/4060

Note: Links to docs will display an error until the docs builds have been completed.

❌ 9 New Failures, 1 Cancelled Job

As of commit d8372fd with merge base a645da6 (image):

NEW FAILURES - The following jobs have failed:

CANCELLED JOB - The following job was cancelled. Please retry:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed label Aug 20, 2025
@samanklesaria samanklesaria changed the base branch from main to stable_accessor August 20, 2025 17:27
@samanklesaria samanklesaria changed the base branch from stable_accessor to pseudo_main August 20, 2025 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant