socket reader support split message by line #692
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wonderflow
reviewed
Aug 7, 2018
reader/rest_reader_models.go
Outdated
| Default: "false", | ||
| Advance: true, | ||
| Description: "是否按'\\n'分隔内容(socket_split_by_line)", | ||
| ToolTip: "开启后，对socket内容按'\\n'进行分隔", |
There was a problem hiding this comment.
是否按行分隔内容(socket_split_by_line)
开启后，对socket内容按行进行分隔
wonderflow
reviewed
Aug 7, 2018
reader/socket/socket.go
Outdated
|
|
||
| if psr.IsSplitByLine{ | ||
| vals := strings.Split(val, "\n") | ||
| for _, value := range vals { |
wonderflow
reviewed
Aug 7, 2018
reader/socket/socket.go
Outdated
| } | ||
| }else{ | ||
| psr.readChan <- socketInfo{address: address, data: val} | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
你这个逻辑块漏写了个地方，tcp的也是 streamSocketReader
wonderflow
reviewed
Aug 7, 2018
reader/socket/socket.go
Outdated
| if ssr.IsSplitByLine { | ||
| vals := strings.Split(val, "\n") | ||
| for _, value := range vals { | ||
| if value = strings.Trim(value, " "); value != "" { |
mockerzzz
force-pushed
the
pdr-6648
branch
3 times, most recently
from
6fbc640 to
ac9e87f
Compare
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.