pisp_be: Stride alignment. #6985
Merged
+110
−52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename the align field in the format structure to opt_align to indicate the optimal alignment for the format. There is no functional change in this commit. Signed-off-by: Naushir Patuck <naush@raspberrypi.com>
|
PS, I think some of our "optimal" alignment fields are wrong? e.g. RGB24 should be 64 and not 32... |
Add a new minimal alignment field to the format structure. This minimal alignment will be used if a stride has been provided by userland. If no stride has been provided by userland (bytesperline == 0), the optimal alignemnt will be used in the stride calculation. Signed-off-by: Naushir Patuck <naush@raspberrypi.com>
|
Yes the 32's are a bit strange. I can only guess it was done for compatibility with Unicam or Codecs (perhaps some earlier versions of software that didn't pay enough attention to strides), or because we felt 64 bytes (for the smallest plane) was too onerous... I think it is harmless to keep this, at least for non-wallpaper image formats and when the width is much greater than 64. |
njhollinghurst
approved these changes
Aug 4, 2025
popcornmix
added a commit
to raspberrypi/firmware
that referenced
this pull request
Aug 13, 2025
See: raspberrypi/linux#6974 kernel: pisp_be: Stride alignment See: raspberrypi/linux#6985 kernel: drm/panel: ilitek-ili9881c: Restore missing lanes configuration for nwe080 panel See: raspberrypi/linux#6987 kernel: drivers: media: pisp_be: Fix alignment for V4L2_PIX_FMT_SRGGB8 See: raspberrypi/linux#6988 kernel: overlays: Fix sc16is752-spi1 emulation See: raspberrypi/linux#6996 kernel: arm64/dma-mapping: Fix arch_sync_dma_for_device to respect dir parameter See: raspberrypi/linux#6995
popcornmix
added a commit
to raspberrypi/rpi-firmware
that referenced
this pull request
Aug 13, 2025
See: raspberrypi/linux#6974 kernel: pisp_be: Stride alignment See: raspberrypi/linux#6985 kernel: drm/panel: ilitek-ili9881c: Restore missing lanes configuration for nwe080 panel See: raspberrypi/linux#6987 kernel: drivers: media: pisp_be: Fix alignment for V4L2_PIX_FMT_SRGGB8 See: raspberrypi/linux#6988 kernel: overlays: Fix sc16is752-spi1 emulation See: raspberrypi/linux#6996 kernel: arm64/dma-mapping: Fix arch_sync_dma_for_device to respect dir parameter See: raspberrypi/linux#6995
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.