Skip to content

Labels not updated #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 6, 2016
Merged

Labels not updated #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions dist/react-chartjs-2.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,21 +100,17 @@ var ChartComponent = _react2['default'].createClass({
},

updateChart: function updateChart() {
var _this = this;

var _props = this.props;
var data = _props.data;
var options = _props.options;

if (!this.chart_instance) return;

if (options) {
_chartJs2['default'].helpers.configMerge(this.chart_instance.options, options);
this.chart_instance.options = _chartJs2['default'].helpers.configMerge(this.chart_instance.options, options);
}

data.datasets.forEach(function (dataset, index) {
_this.chart_instance.data.datasets[index] = dataset;
});
this.chart_instance.config.data = _extends({}, this.chart_instance.config.data, data);

this.chart_instance.update();
},
Expand Down
2 changes: 1 addition & 1 deletion dist/react-chartjs-2.min.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 2 additions & 6 deletions lib/Chart.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,21 +98,17 @@ var ChartComponent = _react2['default'].createClass({
},

updateChart: function updateChart() {
var _this = this;

var _props = this.props;
var data = _props.data;
var options = _props.options;

if (!this.chart_instance) return;

if (options) {
_chartJs2['default'].helpers.configMerge(this.chart_instance.options, options);
this.chart_instance.options = _chartJs2['default'].helpers.configMerge(this.chart_instance.options, options);
}

data.datasets.forEach(function (dataset, index) {
_this.chart_instance.data.datasets[index] = dataset;
});
this.chart_instance.config.data = _extends({}, this.chart_instance.config.data, data);

this.chart_instance.update();
},
Expand Down
9 changes: 5 additions & 4 deletions src/Chart.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,12 +74,13 @@ const ChartComponent = React.createClass({
if (!this.chart_instance) return;

if (options) {
Chart.helpers.configMerge(this.chart_instance.options, options);
this.chart_instance.options = Chart.helpers.configMerge(this.chart_instance.options, options);
}

data.datasets.forEach((dataset, index) => {
this.chart_instance.data.datasets[index] = dataset;
});
this.chart_instance.config.data = {
...this.chart_instance.config.data,
...data
};

this.chart_instance.update();
},
Expand Down