Expand one level of type definition on hover and fix optional field type. #584
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cristianoc
changed the title
zth
approved these changes
Sep 12, 2022
| let labelDeclarationsTypes lds = | ||
| lds |> List.map (fun (ld : Types.label_declaration) -> ld.ld_type) | ||
| in | ||
| match References.digConstructor ~env ~package path with |
There was a problem hiding this comment.
Unrelated to this PR, but it's a little big confusing that both References and Shared has a digConstructor. Or rather, hard to at a glance understand what Shared.digConstructor does (References.digConstructor is pretty easy to guess it has to do with references at least 😄 )
There was a problem hiding this comment.
the shared stuff is leftover that should probably be moved elsewhere
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #557