Skip to content

Add sv.PercentageBarAnnotator() for confidence level bar annotation in specified position #720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 24 commits into from
Jan 23, 2024
Merged

Add sv.PercentageBarAnnotator() for confidence level bar annotation in specified position #720

merged 24 commits into from
Jan 23, 2024

Conversation

xaristeidou
Copy link
Contributor

@xaristeidou xaristeidou commented Jan 11, 2024 •
edited by onuralpszr
Loading

Description

This PR Implements (Fix #695)

This annotator will draw a percentage bar with borders, based on the confidence level for each prediction.
Annotator has the following attributes:

  • height
  • width
  • color
  • border_color
  • position
  • color_lookup

Execution time of annotation process (tested on Ryzen 7 5800H):

  • Exec time for 40 objects: 0.0011143684387207031
  • Mean exec time for each object: 2.7859210968017577e-05

List any dependencies that are required for this change.

No new dependencies required for this change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How has this change been tested, please provide a testcase or example of how you tested the change?

I tested using walking people asset video, prediction providing by YOLOv8. An example is presented below using height = 16, width = 80.
Screenshot from 2024-01-12 01-29-43

Any specific deployment considerations

  • Add new annotator class in Documentation
  • Add image example link reference in class Description in annotators/core.py

Docs

  • Docs updated? NO

@onuralpszr onuralpszr self-requested a review January 17, 2024 16:01
@onuralpszr onuralpszr added documentation Improvements or additions to documentation enhancement New feature or request api:annotator Annotators labels Jan 17, 2024
xaristeidou and others added 19 commits January 22, 2024 21:42
@xaristeidou @onuralpszr
added boundingboxannotator class to re-write class
fbcc211
@xaristeidou @onuralpszr
changed class name and description
b1dbeaf
@xaristeidou @onuralpszr
added PercentageBarAnnotator() to __init__ of package
e809e42
@xaristeidou @onuralpszr
added new attributes of class
ae7360b
@xaristeidou @onuralpszr
arguments description update
f94c0a4
@xaristeidou @onuralpszr
added anchor xy coordinates
a59d845
@xaristeidou @onuralpszr
added if else statements for different anchors
39ef293
@xaristeidou @onuralpszr
corrected border color, added rectangle for percentage
5ed3430
@xaristeidou @onuralpszr
changed default value for height
786942b
@xaristeidou @onuralpszr
deleted unused coordinates and changed type of anchor coords
c70ee87
@xaristeidou @onuralpszr
changed border thickness percentage, extract confidence level
ce19f91
@xaristeidou @onuralpszr
changed if else statements to dictionary mapping
846b337
@xaristeidou @onuralpszr
reformed fill of confidence rectangle, changed border attributes
f3cb8e9
@xaristeidou @onuralpszr
pre-commit spacing
740076d
@onuralpszr
build(docs): 👷 mkdocs-material with imaging dep added for development
65eda0b 
Signed-off-by: Onuralp SEZER <thunderbirdtr@gmail.com>
@onuralpszr
chore: 🧹 folder attiributes ignored
6e9bfc9 
Signed-off-by: Onuralp SEZER <thunderbirdtr@gmail.com>
@pre-commit-ci
fix(pre_commit): 🎨 auto format pre-commit hooks
0817389
@onuralpszr
docs: 📝 PercentageBar Annotator docs and usage added.
c0c541d 
Signed-off-by: Onuralp SEZER <thunderbirdtr@gmail.com>
@onuralpszr
docs: 📝 PercentageBar Annotator image added into core.py
6f87069 
Signed-off-by: Onuralp SEZER <thunderbirdtr@gmail.com>
@onuralpszr
Copy link
Contributor

Google Collab link: https://colab.research.google.com/drive/1SQUkBXcvCB-FGeMb9F6xLH1U30N878jm?usp=sharing

onuralpszr
onuralpszr approved these changes Jan 22, 2024
View reviewed changes
Copy link
Contributor

@onuralpszr onuralpszr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did some gitignore changes and docs typo fixes as well. I also added docs for Percentage Bar I only waiting for pics to be upload so It will render properly.

@onuralpszr
Copy link
Contributor

cc @SkalskiP

SkalskiP
SkalskiP requested changes Jan 22, 2024
View reviewed changes
onuralpszr and others added 2 commits January 23, 2024 04:34
@onuralpszr
feat(core.py): 🚀 Allow custom NumPy array for custom_values in Percen…
2bc58e7 
…tageBarAnnotator

fix(core.py): 🐞 Treat CENTER_OF_MASS the same as CENTER in PercentageBarAnnotator
refactor(core.py): Move border mapping logic to separate method in PercentageBarAnnotator

Signed-off-by: Onuralp SEZER <thunderbirdtr@gmail.com>
@SkalskiP
ready for tests
fa569cb
@onuralpszr onuralpszr merged commit f5f068b into roboflow:develop Jan 23, 2024
@SkalskiP
Copy link
Collaborator

Hi @xaristeidou and @onuralpszr, I just made the final changes. We are merging!

This was referenced Jan 24, 2024
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@onuralpszr onuralpszr onuralpszr approved these changes

@SkalskiP SkalskiP SkalskiP approved these changes

Assignees

@xaristeidou xaristeidou

Labels
api:annotator Annotators documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add annotator sv.PercentageBarAnnotator which shows percentage bar of confidence level in specified position
3 participants
@xaristeidou @onuralpszr @SkalskiP