Skip to content

Conversation

hahnjo
Copy link
Member

@hahnjo hahnjo commented Aug 20, 2025

The interface allows convenient iteration over RBinIndex.


A bit of context on constructing RBinIndexRange: Initially I considered a plain constructor and / or static factory methods that would allow creating bin index ranges without an axis object. That was kind of awkward because of conventions (end is exclusive, so to have a range including RBinIndex::Overflow() we use the invalid RBinIndex), the difference in axis configurations (are flow bins enabled?), and in axis types (a categorical axis will only have an overflow, but not an underflow bin). When discussing with @hageboeck, we came to the conclusion that (for the moment) we prefer creating RBinIndexRanges from axis objects. This can also enforce a number of constraints, for example that the normal bins are actually valid for the given axis configuration. To simplify testing, I opted for a Internal::CreateBinIndexRange that is also used by Get{Normal,Full}Range.

@hahnjo hahnjo self-assigned this Aug 20, 2025
@hahnjo hahnjo requested a review from bellenot as a code owner August 20, 2025 09:23
@hahnjo hahnjo added the in:Hist label Aug 20, 2025
Copy link

github-actions bot commented Aug 20, 2025

Test Results

    21 files      21 suites   3d 15h 6m 48s ⏱️
 3 561 tests  3 424 ✅  0 💤 137 ❌
73 028 runs  72 874 ✅ 17 💤 137 ❌

For more details on these failures, see this check.

Results for commit 8368d62.

♻️ This comment has been updated with latest results.

@hahnjo hahnjo force-pushed the hist-index-range branch 2 times, most recently from e111d60 to a6a2f80 Compare August 22, 2025 07:04
Copy link
Member

@hageboeck hageboeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost nothing to add. 👍

@hahnjo hahnjo force-pushed the hist-index-range branch 2 times, most recently from 38249f4 to ab7466c Compare August 22, 2025 13:08
hahnjo added 2 commits August 22, 2025 15:25
The interface allows convenient iteration over RBinIndex.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants