Skip to content

Make pause resume controller use nav2::LifecycleNode #5427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

redvinaa
Copy link
Contributor

@redvinaa redvinaa commented Aug 7, 2025

Copy link
Contributor

mergify bot commented Aug 7, 2025

@redvinaa, your PR has failed to build. Please check CI outputs and resolve issues.
You may need to rebase or pull in main due to API changes (or your contribution genuinely fails).

Signed-off-by: redvinaa <redvinaa@gmail.com>
@redvinaa redvinaa force-pushed the fix-pause-controller branch from 024ef44 to 85d0677 Compare August 7, 2025 12:58
Copy link
Contributor

mergify bot commented Aug 7, 2025

@redvinaa, your PR has failed to build. Please check CI outputs and resolve issues.
You may need to rebase or pull in main due to API changes (or your contribution genuinely fails).

Signed-off-by: redvinaa <redvinaa@gmail.com>
Signed-off-by: redvinaa <redvinaa@gmail.com>
@SteveMacenski
Copy link
Member

@redvinaa this causes an interesting failure:


[----------] 3 tests from PauseResumeControllerTestFixture
Stack trace (most recent call last):
#11   Object "", at 0xffffffffffffffff, in 
#10   Object "/opt/overlay_ws/build/nav2_behavior_tree/test/plugins/control/test_control_pause_resume_controller", at 0x560593636034, in _start
#9    Object "/usr/lib/x86_64-linux-gnu/libc.so.6", at 0x7f2de02d928a, in __libc_start_main
#8    Object "/usr/lib/x86_64-linux-gnu/libc.so.6", at 0x7f2de02d91c9, in 
#7    Object "/opt/overlay_ws/build/nav2_behavior_tree/test/plugins/control/test_control_pause_resume_controller", at 0x56059364cc6c, in main
#6    Object "/opt/overlay_ws/build/nav2_behavior_tree/test/plugins/control/test_control_pause_resume_controller", at 0x56059368c08e, in testing::UnitTest::Run()
#5    Object "/opt/overlay_ws/build/nav2_behavior_tree/test/plugins/control/test_control_pause_resume_controller", at 0x5605936c6450, in bool testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*)
#4    Object "/opt/overlay_ws/build/nav2_behavior_tree/test/plugins/control/test_control_pause_resume_controller", at 0x5605936a6849, in testing::internal::UnitTestImpl::RunAllTests()
#3    Object "/opt/overlay_ws/build/nav2_behavior_tree/test/plugins/control/test_control_pause_resume_controller", at 0x56059369203a, in testing::TestSuite::Run()
#2    Object "/opt/overlay_ws/build/nav2_behavior_tree/test/plugins/control/test_control_pause_resume_controller", at 0x5605936c6770, in void testing::internal::HandleExceptionsInMethodIfSupported<testing::TestSuite, void>(testing::TestSuite*, void (testing::TestSuite::*)(), char const*)
#1    Object "/opt/overlay_ws/build/nav2_behavior_tree/test/plugins/control/test_control_pause_resume_controller", at 0x5605936a701a, in testing::TestSuite::RunSetUpTestSuite()
#0    Object "/opt/overlay_ws/build/nav2_behavior_tree/test/plugins/control/test_control_pause_resume_controller", at 0x56059365e379, in PauseResumeControllerTestFixture::SetUpTestCase()
Segmentation fault (Address not mapped to object [0x10])

@redvinaa
Copy link
Contributor Author

redvinaa commented Aug 8, 2025

Uups sorry.. At my company we use jazzy so it's very easy to make a mistake developing directly to rolling.
I'm fixing it

Signed-off-by: redvinaa <redvinaa@gmail.com>
@SteveMacenski SteveMacenski merged commit df3effd into ros-navigation:main Aug 8, 2025
11 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants