Credential requester #3
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tyler Pickett <t.pickett66@gmail.com>
Signed-off-by: Tyler Pickett <t.pickett66@gmail.com>
Signed-off-by: Tyler Pickett <t.pickett66@gmail.com>
Signed-off-by: Tyler Pickett <t.pickett66@gmail.com>
Signed-off-by: Tyler Pickett <t.pickett66@gmail.com>
Signed-off-by: Tyler Pickett <t.pickett66@gmail.com>
Signed-off-by: Tyler Pickett <t.pickett66@gmail.com>
Signed-off-by: Tyler Pickett <t.pickett66@gmail.com>
Signed-off-by: Tyler Pickett <t.pickett66@gmail.com>
Signed-off-by: Tyler Pickett <t.pickett66@gmail.com>
Signed-off-by: Tyler Pickett <t.pickett66@gmail.com> Conflicts: lib/rubycas-server-core/credential_requester.rb spec/rubycas-server-core/credential_requester_spec.rb
Signed-off-by: Tyler Pickett <t.pickett66@gmail.com>
Conflicts: Gemfile rubycas-server-core.gemspec
Signed-off-by: Tyler Pickett <t.pickett66@gmail.com>
The Tickets module will hand us back a boolean flag as well as a message
indicating what the specific failure was ('Session Expired',
'Used too many times', etc)
Signed-off-by: Tyler Pickett <t.pickett66@gmail.com>
Signed-off-by: Tyler Pickett <t.pickett66@gmail.com>
Signed-off-by: Tyler Pickett <t.pickett66@gmail.com>
Signed-off-by: Tyler Pickett <t.pickett66@gmail.com>
Signed-off-by: Tyler Pickett <t.pickett66@gmail.com>
Signed-off-by: Tyler Pickett <t.pickett66@gmail.com>
Conflicts: .rvmrc Gemfile Guardfile lib/rubycas-server-core.rb lib/rubycas-server-core/core_ext.rb lib/rubycas-server-core/tickets.rb lib/rubycas-server-core/util.rb spec/rubycas-server-core/core_ext_spec.rb spec/rubycas-server-core/tickets_spec.rb spec/rubycas-server-core/util_spec.rb spec/spec_helper.rb
Using #empty? here works nicely when you pass strings but sometimes we'll get nil since most of these values are coming from hashes. Signed-off-by: Tyler Pickett <t.pickett66@gmail.com>
Signed-off-by: Tyler Pickett <t.pickett66@gmail.com>
Signed-off-by: Tyler Pickett <t.pickett66@gmail.com>
|
This isn't really an outline anymore. But it could use some refactoring. |
Signed-off-by: Tyler Pickett <t.pickett66@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Outline credential requester, this is an extract from pull request #2