Update phpstan to 2.x #2252
Merged
Update phpstan to 2.x #2252
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sidz
force-pushed
the
update-phpstan
branch
6 times, most recently
from
d467709 to
9f81f52
Compare
ruflin
reviewed
Jul 24, 2025
| @@ -18,9 +18,9 @@ | |||
| /** | |||
| * @internal | |||
| */ | |||
| #[Group('unit')] | |||
There was a problem hiding this comment.
This implies all test in here are unit tests?
There was a problem hiding this comment.
yup.
In my projects I usually use different test suites instead of groups. so Unit and Functional tests are placed in the different folders, ie:
tests/Unit
tests/Functional
|
Nice update. Should we mention this in the changelog? Not sure TBH. |
ruflin
approved these changes
Jul 24, 2025
It makes sense @ruflin. I forgot to add a new line into Changelog. Changelog updated |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates phpstan to the 2.1 and resolve some of the issues.